-
Notifications
You must be signed in to change notification settings - Fork 375
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add support for TCP healthcheck #346
feat: Add support for TCP healthcheck #346
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
35baf65
to
135ed17
Compare
135ed17
to
eeb52d6
Compare
@imrannayer done! Thanks for the hint! |
Add support for tcp health check
eeb52d6
to
1a74709
Compare
@ps-occrp seems like |
Add support for extra parameters
@imrannayer Thanks for picking this, I have added this parameters. |
/gcbrun |
@ps-occrp can u also add parameters in variables.tf file. |
Add support for all optional health check fields for different checks
@imrannayer done, I have additionally added optional missing parameters in other types of health checks to keep them all in sync. |
/gcbrun |
This adds support for TCP health checks and fixes #129 , #258 and #272