Add notification configuration

[KishoreNamala]

Hi,

Any plans to include notification configuration on the bucket in this module anytime soon ? I currently use this module and wondering if there's a way to do the notifications independently and still use this module...should I do this after the bucket is created by using a depends-on ?

I can try taking this up, but don't know where to get started for working as a contributor.

Thanks
Kishore

[morgante]

We could certainly add it, if you'd be willing to take this on it'd be great. This explains how to set up tests and such, then you could just add a new notifications variable to the module.

Based on that variable, it should create the required google_storage_notification resources.

[KishoreNamala]

We could certainly add it, if you'd be willing to take this on it'd be great. This explains how to set up tests and such, then you could just add a new notifications variable to the module.

Based on that variable, it should create the required google_storage_notification resources.

can you clarify a bit more on this test environment section in set up

I don't have permissions at the folder level. So, what's my alternative here ?

[morgante]

If you don't have permission to create projects yourself, you can also reuse an existing project. You'll simply need to manually create a test/setup.sh file which includes content like:

export TF_VAR_project_id='my-project-id'
export SERVICE_ACCOUNT_JSON='my-sa-json'

See this file for more details: https://github.com/terraform-google-modules/terraform-google-cloud-storage/blob/master/test/setup/make_source.sh

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days

[KishoreNamala]

I'll be getting back to this one soon.

[github-actions]

This issue is stale because it has been open 60 days with no activity. Remove stale label or comment or this will be closed in 7 days