Support for Terraform 0.12 (fixes #55)

[eliasdorneles]

Hello,

I tried upgrading the module to Terraform 0.12, the automated upgrade command terraform 0.12upgrade) does a good job.
I only had to solve manually one section (which had a comment explaining with the proper context).

I've also added a few lines to README pointing people to use the v1.10.0 version if they're on Terraform 0.11.

Does this look good?

[eliasdorneles]

I had to update the type constraint for extra_tags as well.

Docs here:

• https://www.terraform.io/docs/configuration/types.html#structural-types
• https://www.terraform.io/upgrade-guides/0-12.html#type-constraints-on-variables

[Gazler]

I have tried this out and get the following error when I don't include an eip value:

Error: bastion: invalid tag attributes: value missing

If I make this change:

  tags = concat(
    [
      {
        "key"                 = "Name"
        "value"               = var.name
        "propagate_at_launch" = true
      },
-      {
-        "key"                 = "EIP"
-        "value"               = var.eip
-        "propagate_at_launch" = true
-      },
    ],
    var.extra_tags,
  )

Then it works.

Here's the plan with the missing value:

      + tags                      = [
          + {
              + "key"                 = "Name"
              + "propagate_at_launch" = "true"
              + "value"               = "bastion"
            },
          + {
              + "key"                 = "EIP"
              + "propagate_at_launch" = "true"
            },
        ]

[CarpathianUA]

I would like to this merged :)

[allan-simon]

@eliasdorneles ping :) , I think with @Gazler modification it should be good ?

[eliasdorneles]

@allan-simon if i do that, then i'll break the behavior documented in the README:

eip - EIP to put into EC2 tag (can be used with scripts like https://github.com/skymill/aws-ec2-assign-elastic-ip, default - empty value)

... because the var.eip wouldn't be used anywhere.

I dunno what's best to do here, tbh.

[antonbabenko]

v2.0.0 of this module is Terraform 0.12 ready.