Add associate address permission #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Addition is fine, but name of policy should be different, because it is not just about S3 any more. Please change that and we can merge it. |
|
What do you think about this policy name? "s3_readonly-allow_associateaddress" |
|
Yes, @michael-henderson |
added 2 commits
May 23, 2017 22:50
…only and AssociateAddress, and run terraform fmt
|
@antonbabenko I added two different example tf files (one with AssociateAddress, and one with s3_readonly) and edited the README to reflect that change. I also ran terraform fmt to normalize formatting. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using this module with only s3 permissions, the instance fails to associate the created EIP when userdata runs. Gives a permission denied error unless you allow it in the IAM policy.