Option to use instance public IP (not EIP) #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good idea. I normally don't need this, because subnet where bastion host runs has "assign public IP by default = true" (in VPC). I have left minor comments and then I will merge. |
| @@ -44,3 +44,6 @@ variable "subnet_ids" { | |||
| variable "eip" { | |||
| default = "" | |||
| } | |||
| variable assign_public_ip { | |||
There was a problem hiding this comment.
Quote var name as in other places
| @@ -67,6 +67,7 @@ resource "aws_launch_configuration" "bastion" { | |||
| "${compact(concat(list(aws_security_group.bastion.id), split(",", "${var.security_group_ids}")))}" | |||
| ] | |||
| iam_instance_profile = "${var.iam_instance_profile}" | |||
| associate_public_ip_address = "${var.assign_public_ip}" | |||
There was a problem hiding this comment.
Let's rename assign_public_ip into associate_public_ip_address to make it as similar to name as possible
|
Thanks for a detailed review, I've updated the code |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found it handy to just allocate dynamic public IP instead of scripting EIP association. Please let me know what do you think.
By default set to
falseto maintain backwards compatibility