Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change redshift_route_table_ids ? #738

Closed
officel opened this issue Jan 26, 2022 · 4 comments · Fixed by #739
Closed

change redshift_route_table_ids ? #738

officel opened this issue Jan 26, 2022 · 4 comments · Fixed by #739

Comments

@officel
Copy link

officel commented Jan 26, 2022

Description

The private route table assigned to the redshift subnet is changed to the public route table.

Versions

Terraform v1.1.4
on linux_amd64
+ provider registry.terraform.io/hashicorp/aws v3.73.0

Reproduction

I'm trying to use github actions to bring it up to date.
Today I noticed a diff.

Code Snippet to Reproduce

no set var.enable_public_redshift, so default is false right?

Expected behavior

no changes.

Actual behavior

Changes to Outputs:
  ~ vpc = {
      ~ database_route_table_ids                    = [
          - "rtb-0dd99",
          - "rtb-01265",
          - "rtb-02445",
        ] -> [
          + "rtb-0dd99",
          + "rtb-01265",
          + "rtb-02445",
        ]
      ~ elasticache_route_table_ids                 = [
          - "rtb-0dd99",
          - "rtb-01265",
          - "rtb-02445",
        ] -> [
          + "rtb-0dd99",
          + "rtb-01265",
          + "rtb-02445",
        ]
      ~ redshift_route_table_ids                    = [
          - "rtb-0dd99",
          - "rtb-01265",
          - "rtb-02445",
        ] -> [
          + "rtb-0c6a7",
        ]
        # (106 unchanged elements hidden)
    }

Additional context

Caused by this change
https://github.com/terraform-aws-modules/terraform-aws-vpc/pull/729/files#diff-de6c47c2496bd028a84d55ab12d8a4f90174ebfb6544b8b5c7b07a7ee4f27ec7R253

Ignore the flag and use the public subnet.

@antonbabenko
Copy link
Member

Thanks for opening this issue and providing a specific line that broke it. I will make a fix now.

@antonbabenko
Copy link
Member

This issue has been resolved in version 3.11.4 🎉

@officel
Copy link
Author

officel commented Jan 26, 2022

Thank you for your quick response and release!!

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants