feat: Added support for deduplication_scope and fifo_throughput_limit
#32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
changed the title
input_deduplication_scope input_fifo_throughput_limit and fix exampleinput_deduplication_scope and input_fifo_throughput_limit
antonbabenko
requested changes
Nov 22, 2021
antonbabenko
changed the title
input_deduplication_scope and input_fifo_throughput_limitdeduplication_scope and fifo_throughput_limit
kamilhristov
force-pushed
the
master
branch
2 times, most recently
from
a6ba7cb to
edce090
Compare
|
@antonbabenko comments addressed, please review 🙏 |
antonbabenko
requested changes
Nov 22, 2021
There was a problem hiding this comment.
Please update versions.tf to use Terraform 0.13.1 at least, and AWS provider when the feature you are adding was introduced.
Copy this - https://github.com/terraform-aws-modules/terraform-aws-vpc/blob/master/versions.tf
Get account_id from aws_caller_identity
|
Good job! Here we go 🎉 v3.2.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Fixes #31
Breaking Changes
None.
How Has This Been Tested?
examples/*projects