Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Added cloudwatch log group skip_destroy and log_group_class #553

Conversation

magreenbaum
Copy link
Member

Description

Adds skip_destroy and log_group_class for the cloudwatch log groups.

Motivation and Context

Adds skip_destroy and log_group_class for the cloudwatch log groups.

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@magreenbaum magreenbaum requested review from antonbabenko and bryantbiggs and removed request for antonbabenko June 11, 2024 23:09
@antonbabenko antonbabenko changed the title feat: Cloudwatch log group skip_destroy and log_group_class feat: Added cloudwatch log group skip_destroy and log_group_class Jun 12, 2024
@antonbabenko antonbabenko merged commit 12f4e91 into terraform-aws-modules:master Jun 12, 2024
23 checks passed
antonbabenko pushed a commit that referenced this pull request Jun 12, 2024
## [6.7.0](v6.6.0...v6.7.0) (2024-06-12)

### Features

* Added cloudwatch log group `skip_destroy` and `log_group_class` ([#553](#553)) ([12f4e91](12f4e91))
@antonbabenko
Copy link
Member

This PR is included in version 6.7.0 🎉

@magreenbaum magreenbaum deleted the feat/cloudwatch_log_group_class_and_skip_destroy branch June 13, 2024 11:49
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 14, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants