Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add db_instance_role_association functionality #508

Merged
merged 6 commits into from
Oct 23, 2023
Merged

feat: Add db_instance_role_association functionality #508

merged 6 commits into from
Oct 23, 2023

Conversation

magreenbaum
Copy link
Member

@magreenbaum magreenbaum commented Aug 13, 2023 •
edited by bryantbiggs
Loading

Description

#493
#464

Motivation and Context

Breaking Changes

No.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Sep 13, 2023
@magreenbaum
Copy link
Member Author

Unstale

antonbabenko
antonbabenko requested changes Sep 13, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good, some minor comments remain.

modules/db_instance_role_association/main.tf Outdated Show resolved Hide resolved
examples/role-association-postgres/main.tf Outdated Show resolved Hide resolved
modules/db_instance_role_association/main.tf Outdated Show resolved Hide resolved
modules/db_instance_role_association/variables.tf Show resolved Hide resolved
@github-actions github-actions bot removed the stale label Sep 14, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Oct 22, 2023
@magreenbaum
Copy link
Member Author

unstale

@github-actions github-actions bot removed the stale label Oct 23, 2023
antonbabenko
antonbabenko approved these changes Oct 23, 2023
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@antonbabenko antonbabenko merged commit ed027d7 into terraform-aws-modules:master Oct 23, 2023
antonbabenko pushed a commit that referenced this pull request Oct 23, 2023
@semantic-release-bot
chore(release): version 6.2.0 [skip ci]
9c264b9 
## [6.2.0](v6.1.1...v6.2.0) (2023-10-23)

### Features

* Add `db_instance_role_association` functionality ([#508](#508)) ([ed027d7](ed027d7))
@antonbabenko
Copy link
Member

This PR is included in version 6.2.0 🎉

@magreenbaum magreenbaum deleted the feat/db_instance_role_association branch October 23, 2023 12:22
@github-actions GitHub Actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for aws_db_instance_role_association Add - aws_db_instance_role_association
2 participants
@magreenbaum @antonbabenko