Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add output aws_rds_cluster.this.hosted_zone_id #125

Merged
merged 7 commits into from
Aug 19, 2020

Conversation

felixb
Copy link
Contributor

@felixb felixb commented Apr 24, 2020

Description

This allows setting route53 aliases.

Motivation and Context

I want to set an alias record in route53.

Breaking Changes

None.

How Has This Been Tested?

Did not test. It's just a new output.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
This allows setting route53 aliases.
@felixb felixb changed the title output aws_rds_cluster.this.hosted_zone_id Add output aws_rds_cluster.this.hosted_zone_id Apr 24, 2020
@felixb felixb changed the title Add output aws_rds_cluster.this.hosted_zone_id feat: Add output aws_rds_cluster.this.hosted_zone_id Apr 24, 2020

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
outputs.tf Outdated Show resolved Hide resolved

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Co-authored-by: Bryant Biggs <[email protected]>
@bryantbiggs
Copy link
Member

@antonbabenko 👍

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@antonbabenko antonbabenko merged commit 6e592b7 into terraform-aws-modules:master Aug 19, 2020
@antonbabenko
Copy link
Member

Thanks, @felixb !

v2.22.0 has been just released.

tomasbackman pushed a commit to qapital/terraform-aws-rds-aurora that referenced this pull request Nov 16, 2020
se-dsingh pushed a commit to secretescapes/terraform-aws-rds-aurora that referenced this pull request Nov 20, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants