feat: Added support for GuardDuty Findings format #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AndrewFarley
changed the title
|
Fixes #48 |
|
Ping, can we get this merged so I can stop using my forked version of this repo? :) |
antonbabenko
changed the title
|
Thank you, @AndrewFarley and @iogi ! v4.18.0 has been just released. |
This was referenced Oct 1, 2021
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This adds formatting for Guardduty Findings. This is based on #127 but resolving the feedback and adding tests. Thank you to @iogi for their original contribution I just want to see this to the finish line.
Motivation and Context
The Guard Duty findings were not properly reported in this module and were hidden away in the details of this SNS event structure.
Breaking Changes
NO
How Has This Been Tested?
Screenshot
Closes #127