feat: add support for nested messages #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielsepulvedab
changed the title
|
v4.16.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR includes some more logic in the creation of the attachments in the
default_notificationsmethod.Motivation and Context
The
valueattribute of the attachments only accept strings, so when not sent as such Slack is ignoring them. This makes some important information to be missing in the Slack message.Breaking Changes
This change doesn't break backwards compatibility.
How Has This Been Tested?
examples/*projectsI tested the change with Pytest and added a new case in which the new behavior can be seen.
I also created the resources in AWS with a
aws_cloudwatch_event_ruleto send the events to the SNS topic.Both tests worked as expected.
Result
Before this PR:
After this PR:
