-
-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add default value for alert_manager_definition
#3
fix: Add default value for alert_manager_definition
#3
Conversation
alert_manager_definition
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
after updating the heredocs format, please run pre-commit run -a
to update the documentation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @bryankaraffa
### [2.1.2](v2.1.1...v2.1.2) (2022-04-26) ### Bug Fixes * Add default value for `alert_manager_definition` ([#3](#3)) ([a66025f](a66025f))
This PR is included in version 2.1.2 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This fixes and issue with the latest version of this module when no value is provided for
alert_manager_definition
and the current default value [null
] is used:This error matches the aws provider documentation and
definition
is requiredA empty string value [
""
] will not work for this either and produces this error:This PR changes the module to use a very basic definition as the default value for
alert_manager_definition
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)