Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed concurrent builds #65

Merged
merged 3 commits into from
Oct 26, 2020

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Oct 23, 2020

A bit of fixes relative to paths processing in case of concurrent builds and in case of symlinks in a content root directories.

Git log:
95b41be fix: paths creation in case of concurrent builds, closes #64
80d0926 Don't silently ignore content by symlinks
e1320a7 fix: take build_plan into account when computing hash

TODO:
  Check symlink relativity to a content root and if it refers to
  outside and doesn't filtered then raise an error and abort packaging.
@antonbabenko antonbabenko changed the title A bit of fixes fix: Fixed concurrent builds Oct 26, 2020
@antonbabenko antonbabenko merged commit 67ea9ac into terraform-aws-modules:master Oct 26, 2020
@antonbabenko
Copy link
Member

Thanks @ahlinc !

v1.25.0 has been just released.

@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FileExistsError: [Errno 17] File exists: 'builds'
2 participants