Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fix package.py commands after :zip not being executed #606

Merged
merged 7 commits into from
Aug 23, 2024

Conversation

mleziva
Copy link
Contributor

@mleziva mleziva commented Aug 1, 2024

Description

When using the commands option in source_path, commands after ":zip" were not being executed. This PR resolves that unexpected behavior

Motivation and Context

The root cause was that the commands loop read all provided commands, but it didn't add the commands after a ":zip" command to the plan file. This was remediated by adding a check after the commands loop exited to add the remaining commands to the steps.

Breaking Changes

None

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

Sorry, something went wrong.

mleziva added 2 commits August 1, 2024 15:29

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
sh commands after :zip were not being executed
@mleziva mleziva changed the title package.py - Fix commands after :zip not being executed fix - package.py commands after :zip not being executed Aug 1, 2024
@mleziva mleziva changed the title fix - package.py commands after :zip not being executed fix: package.py commands after :zip not being executed Aug 1, 2024
@mleziva mleziva changed the title fix: package.py commands after :zip not being executed fix: Fix package.py commands after :zip not being executed Aug 1, 2024
mleziva added 3 commits August 1, 2024 16:12
@mleziva
Copy link
Contributor Author

mleziva commented Aug 19, 2024

@antonbabenko , can you please review when you get a chance. Thanks!

Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@pdecat what do you think?

tests/fixtures/node-app/package-lock.json Outdated Show resolved Hide resolved
@mleziva mleziva requested a review from antonbabenko August 20, 2024 12:36
@antonbabenko antonbabenko merged commit 801e69c into terraform-aws-modules:master Aug 23, 2024
29 checks passed
antonbabenko pushed a commit that referenced this pull request Aug 23, 2024
## [7.8.1](v7.8.0...v7.8.1) (2024-08-23)

### Bug Fixes

* Fix package.py commands after :zip not being executed ([#606](#606)) ([801e69c](801e69c))
@antonbabenko
Copy link
Member

This PR is included in version 7.8.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants