Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed constant drift with Lambda logging configuration #551

Merged
merged 3 commits into from
Mar 22, 2024

Conversation

antonbabenko
Copy link
Member

@antonbabenko antonbabenko commented Mar 22, 2024

A simple configuration like this was marking version, qualified_arn and qualified_invoke_arn as (known after apply):

  logging_log_format = "JSON"

The user used to pass some extra arguments to reduce noise:

  logging_log_group             = "/aws/lambda/adapting-tadpole-test"
  logging_application_log_level = "DEBUG"
  logging_system_log_level      = "INFO"

This PR sets defaults for log level to avoid such behavior.

Ideally, this should be fixed in Terraform AWS provider. Related issues:
hashicorp/terraform-provider-aws#33383
hashicorp/terraform-provider-aws#33955

@antonbabenko antonbabenko merged commit 8f97707 into master Mar 22, 2024
29 checks passed
@antonbabenko antonbabenko deleted the fix-logging-noise branch March 22, 2024 11:55
antonbabenko pushed a commit that referenced this pull request Mar 22, 2024
## [7.2.3](v7.2.2...v7.2.3) (2024-03-22)

### Bug Fixes

* Fixed constant drift with Lambda logging configuration ([#551](#551)) ([8f97707](8f97707))
@antonbabenko
Copy link
Member Author

This PR is included in version 7.2.3 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 22, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant