Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set timeouts only when values are given #522

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

dbast
Copy link
Contributor

@dbast dbast commented Dec 14, 2023

Description

Fixes #486

Motivation and Context

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

main.tf Outdated Show resolved Hide resolved
@dbast dbast changed the title fix: Ignore timeouts state values fix: Set timeouts only when values are given Jan 15, 2024
@dbast
Copy link
Contributor Author

dbast commented Jan 15, 2024

@antonbabenko thanks... rebased, changed and tested via internal terraform enterprise deployment.... ready for another review.

@antonbabenko antonbabenko merged commit b4bfe39 into terraform-aws-modules:master Jan 15, 2024
29 checks passed
antonbabenko pushed a commit that referenced this pull request Jan 15, 2024
### [6.7.1](v6.7.0...v6.7.1) (2024-01-15)

### Bug Fixes

* Set timeouts only when values are given ([#522](#522)) ([b4bfe39](b4bfe39))
@antonbabenko
Copy link
Member

This PR is included in version 6.7.1 🎉

Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 15, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
2 participants