Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add module wrappers #479

Merged

Conversation

matheusmazzoni
Copy link
Contributor

@matheusmazzoni matheusmazzoni commented Jul 4, 2023

Description

This is a bit rough implementation of a wrapper pattern for all modules in this repository.

Motivation and Context

Currently I need to create a huge amount of lambdas within some projects using terragrunt. So that it doesn't become a gigantic task and with SEVERAL files, I based myself on the repositories that already implement this method of wrappers, such as, for example, the S3 Bucket and SNS module. I believe this solves my problem of managing several files within my repository and for other people who use it.

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@matheusmazzoni
Copy link
Contributor Author

I forgot to put reviewers, sorry :(
Could you review @antonbabenko?

@antonbabenko antonbabenko merged commit b5e9346 into terraform-aws-modules:master Jul 5, 2023
antonbabenko pushed a commit that referenced this pull request Jul 5, 2023
## [5.2.0](v5.1.0...v5.2.0) (2023-07-05)

### Features

* Add module wrappers ([#479](#479)) ([b5e9346](b5e9346))
@antonbabenko
Copy link
Member

This PR is included in version 5.2.0 🎉

@github-actions
Copy link

github-actions bot commented Aug 5, 2023

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants