Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Set the default value of replacement_security_group_ids to null #434

Merged

Conversation

ricoli
Copy link
Contributor

@ricoli ricoli commented Mar 10, 2023

Description

Fix the validation error caused by #422 (released in version 4.12.0), and reported in #433 which is being triggered because the default value of replacement_security_group_ids is [], not null.

Motivation and Context

Fixes #433

Breaking Changes

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@ricoli ricoli changed the title fix: set the default value of replacement_security_group_ids to null fix: Set the default value of replacement_security_group_ids to null Mar 10, 2023
@antonbabenko antonbabenko merged commit a2d9ff9 into terraform-aws-modules:master Mar 10, 2023
antonbabenko pushed a commit that referenced this pull request Mar 10, 2023
### [4.12.1](v4.12.0...v4.12.1) (2023-03-10)

### Bug Fixes

* Set the default value of replacement_security_group_ids to null ([#434](#434)) ([a2d9ff9](a2d9ff9))
@antonbabenko
Copy link
Member

This PR is included in version 4.12.1 🎉

@ricoli ricoli deleted the fix-validation-firing branch March 10, 2023 15:54
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Apr 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

"Missing required argument" error with version 4.12.0
2 participants