-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added configuration options to replace security groups on destroy of Lambda function #422
feat: Added configuration options to replace security groups on destroy of Lambda function #422
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Minor improvement and docs update.
5053a97
to
e21c20c
Compare
## [4.12.0](v4.11.0...v4.12.0) (2023-03-10) ### Features * Added configuration options to replace security groups on destroy of Lambda function ([#422](#422)) ([2d92236](2d92236))
This PR is included in version 4.12.0 🎉 |
Hi Ricardo and Anton. Are you sure that you introduced this feature like intended? The docs of the lambda module say that the attributes replace_security_groups_on_destroy and replacement_security_group_ids are optional. But when I use the new version of the module, without changing my terraform code, my terraform deploy fails:
|
@nils-at-slashwhy #433 is already about it. I will look at it during the next couple of hours and fix it. |
Great! Thank you very much :) |
Oh no, I wonder if replacement_security_group_ids should also be |
@ricoli Probably. Please try it if you have time. |
I'm on it - sorry about the trouble! I should have tested it again after changing the default value from |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Add support for the newly introduced
replace_security_groups_on_destroy
andreplacement_security_group_ids
lambda function arguments in v4.54.0Motivation and Context
Implements #418
Breaking Changes
None
How Has This Been Tested?
examples/*
to demonstrate and validate my change(s)examples/*
projectspre-commit run -a
on my pull request