Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add max session duration for IAM role #391

Merged
merged 4 commits into from
Apr 14, 2023
Merged

feat: Add max session duration for IAM role #391

merged 4 commits into from
Apr 14, 2023

Conversation

sindrig
Copy link
Contributor

@sindrig sindrig commented Dec 13, 2022

Description

Add ability to specify maximum session duration for the created role.

Motivation and Context

We're using this module to create all our services. In development, the developers assume the roles of the services to mimic the permissions they have. By default the sessions can have a maximum duration of an hour (3600 seconds) and that means that developers need to re-assume multiple times per day.

Breaking Changes

There should be no changes as the default remains the same.

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@sindrig sindrig changed the title Add max session duration for IAM role feat: Add max session duration for IAM role Dec 13, 2022
@sindrig sindrig force-pushed the master branch 2 times, most recently from d5b8ee3 to 822b4c4 Compare December 20, 2022 12:07
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Jan 20, 2023
@sindrig
Copy link
Contributor Author

sindrig commented Jan 20, 2023

@antonbabenko any chance of getting a review on this?

@github-actions github-actions bot removed the stale label Jan 21, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Mar 12, 2023
@sindrig
Copy link
Contributor Author

sindrig commented Mar 12, 2023

Still relevant

@github-actions github-actions bot removed the stale label Mar 13, 2023
@github-actions
Copy link

This PR has been automatically marked as stale because it has been open 30 days
with no activity. Remove stale label or comment or this PR will be closed in 10 days

@github-actions github-actions bot added the stale label Apr 13, 2023
sindrig added 2 commits April 13, 2023 08:14
@sindrig
Add max session duration for IAM role
648283e 
Add role_maximum_session_duration to example
@sindrig
Update README
19d1003 
Update README (terraform-docs working correctly)
@sindrig
Copy link
Contributor Author

sindrig commented Apr 13, 2023

@antonbabenko any chance on getting this merged?

@antonbabenko
Copy link
Member

Please fix the CI by pinning the version of the VPC module to version ~> 3.0

@github-actions github-actions bot removed the stale label Apr 14, 2023
@sindrig
Copy link
Contributor Author

sindrig commented Apr 14, 2023

Please fix the CI by pinning the version of the VPC module to version ~> 3.0

Done!

@antonbabenko antonbabenko merged commit 3a21ac5 into terraform-aws-modules:master Apr 14, 2023
antonbabenko pushed a commit that referenced this pull request Apr 14, 2023
@semantic-release-bot
chore(release): version 4.14.0 [skip ci]
b2168c4 
## [4.14.0](v4.13.0...v4.14.0) (2023-04-14)

### Features

* Add max session duration for IAM role ([#391](#391)) ([3a21ac5](3a21ac5))
@antonbabenko
Copy link
Member

This PR is included in version 4.14.0 🎉

@antonbabenko antonbabenko mentioned this pull request Apr 18, 2023
Merged
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sindrig @antonbabenko