fix: Skips the runtime test when building in docker #362
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
lorengordon
force-pushed
the
docker-skip-runtime-check
branch
from
8bc3573 to
0220f31
Compare
antonbabenko
changed the title
antonbabenko
approved these changes
Oct 21, 2022
I'm unable to test at the moment (not at work) but the changes included fixed the issue for me so I'm fairly certain this will resolve the issue |
antonbabenko
pushed a commit
that referenced
this pull request
Oct 21, 2022
### [4.1.4](v4.1.3...v4.1.4) (2022-10-21) ### Bug Fixes * Skips the runtime test when building in docker ([#362](#362)) ([2055256](2055256))
|
This PR is included in version 4.1.4 🎉 |
3 tasks
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This skips the runtime test when building in docker.
Motivation and Context
In the plan phase, package.py is executed on the local machine, even when the build is configured to use docker. This means the runtime check was executed on the local machine, and therefore required that the
runtimebe present in the local machine PATH. But when using docker, the runtime should only be required in the container, not on the local machine.Since by default the image used is based on the runtime, we skip the runtime check when using docker to build the package. However, a note is added to the readme for cases where the user customizes the
docker_image, as that can lead to a success in the plan phase that would fail in the apply phase, if they are not careful to match up the runtime and the image.Fixes #361
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request