-
-
Notifications
You must be signed in to change notification settings - Fork 693
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Added support for Code Signing Configuration #351
feat: Added support for Code Signing Configuration #351
Conversation
@bryantbiggs I appreciate your review and feedback for #262. I addressed all of those in this PR. Could I get your review for this please? |
d9a373a
to
dc3930d
Compare
Signed-off-by: Thiha Soe <[email protected]>
Signed-off-by: Thiha Soe <[email protected]>
dc3930d
to
cc6e9e6
Compare
👍 looks good to me @bryantbiggs thoughts? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, @antonbabenko what do you think
Thanks to everyone! I will review it and merge it later this week. I have some other things to do before. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I tried to run example/code-signing and this was the error:
╷
│ Error: error starting Signing Job: ValidationException: StartSigningJobRequest:source:version should not be empty
│ {
│ RespMetadata: {
│ StatusCode: 400,
│ RequestID: "35c2c96f-8ac7-488d-a2a2-779a9aad584a"
│ },
│ Code_: "InvalidJobParameters",
│ Message_: "StartSigningJobRequest:source:version should not be empty"
│ }
│
│ with aws_signer_signing_job.this,
│ on main.tf line 52, in resource "aws_signer_signing_job" "this":
│ 52: resource "aws_signer_signing_job" "this" {
│
╵
Please take a look and fix it.
taking a look |
This error occurs if S3 isn't ready to do the versioning yet. S3 object has version id of
|
Signed-off-by: Thiha Soe <[email protected]>
Signed-off-by: Thiha Soe <[email protected]>
Signed-off-by: Thiha Soe <[email protected]>
@antonbabenko I added 5mins timer before uploading the s3 object in the example, example will run fine at first attempt now. Example README is also updated with time_sleep resource information and main README's example section has been updated as well. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. I have updated the example a bit and verified it.
## [4.2.0](v4.1.4...v4.2.0) (2022-10-22) ### Features * Added support for Code Signing Configuration ([#351](#351)) ([dd40178](dd40178))
This PR is included in version 4.2.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR adds code_signing_config_arn support.
The change doesn't effect any other things except it takes in code_signing_config_arn if user wants to provide one.