Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Fixed issue with zip renaming on Windows platform #32

Merged

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Jun 16, 2020

Git log:
9ddf8c7 package.py - Detect OS and use correct executable for pip requirements
c5beb69 package.tf - Detect OS and use appropriate executable name
cf507ea package.py - Fixed issue with zip renaming on Win platform

@ahlinc ahlinc force-pushed the fix/os-win-zip-renaming branch from 9ddf8c7 to 6199039 Compare June 18, 2020 13:07
@ahlinc ahlinc force-pushed the fix/os-win-zip-renaming branch from 6199039 to 73d2a8b Compare June 18, 2020 13:11
@ahlinc ahlinc marked this pull request as ready for review June 18, 2020 13:46
@antonbabenko antonbabenko changed the title package.py - Fixed issue with zip renaming on Win platform fix: Fixed issue with zip renaming on Windows platform Jun 18, 2020
@antonbabenko antonbabenko merged commit 72d887b into terraform-aws-modules:master Jun 18, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

terraform apply fails Windows during packaging
3 participants