Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add support for Lambda Function URL resource #308

Merged
merged 10 commits into from
Apr 27, 2022
Merged

feat: Add support for Lambda Function URL resource #308

merged 10 commits into from
Apr 27, 2022

Conversation

spitzzz
Copy link
Contributor

@spitzzz spitzzz commented Apr 25, 2022 •
edited by antonbabenko
Loading

Description

Adds support for the new aws_lambda_function_url resouce type documented here.

Motivation and Context

Adds support for creating URLs for lambda functions

Fixes #306

Breaking Changes

No

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@spitzzz spitzzz changed the title Add basic support for lambda function url resource feat: Add basic support for lambda function url resource Apr 25, 2022
antonbabenko
antonbabenko reviewed Apr 25, 2022
View reviewed changes
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Please add a new module call into complete example for Lambda function with all available arguments set (e.g. cors).

outputs.tf Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@spitzzz spitzzz changed the title feat: Add basic support for lambda function url resource feat: Add support for lambda function url resource Apr 25, 2022
@spitzzz spitzzz requested a review from antonbabenko April 26, 2022 19:35
antonbabenko
antonbabenko requested changes Apr 27, 2022
View reviewed changes
outputs.tf Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title feat: Add support for lambda function url resource feat: Add support for Lambda Function URL resource Apr 27, 2022
@antonbabenko antonbabenko merged commit c239f9d into terraform-aws-modules:master Apr 27, 2022
antonbabenko pushed a commit that referenced this pull request Apr 27, 2022
@semantic-release-bot
chore(release): version 3.2.0 [skip ci]
19b9f11 
## [3.2.0](v3.1.1...v3.2.0) (2022-04-27)

### Features

* Add support for Lambda Function URL resource ([#308](#308)) ([c239f9d](c239f9d))
@antonbabenko
Copy link
Member

This PR is included in version 3.2.0 🎉

@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@antonbabenko antonbabenko antonbabenko requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support AWS Lambda URLs
2 participants
@spitzzz @antonbabenko