Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Added support for keep_remotely in docker-build submodule #284

Merged
merged 3 commits into from
Mar 18, 2022
Merged

fix: Added support for keep_remotely in docker-build submodule #284

merged 3 commits into from
Mar 18, 2022

Conversation

michaelhelmick
Copy link
Contributor

@michaelhelmick michaelhelmick commented Mar 18, 2022 •
edited by antonbabenko
Loading

Description

Supports keep_remotely docker_registry_image variable.
Fixes #283

Motivation and Context

Workaround for problems described in #283

Breaking Changes

None, defaults to false as the provider has it set.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@michaelhelmick michaelhelmick changed the title Fixes #283, support keep_remotely docker_registry_image variable Fix #283, support keep_remotely docker_registry_image variable Mar 18, 2022
@michaelhelmick michaelhelmick changed the title Fix #283, support keep_remotely docker_registry_image variable fix: Fix #283, support keep_remotely docker_registry_image variable Mar 18, 2022
@michaelhelmick
Copy link
Contributor Author

I tried running pre-commit run -a with 3 different versions of terraform and ran into the same issue I did last time. Would love if this was more streamlined, not sure what I am doing wrong.

@antonbabenko antonbabenko changed the title fix: Fix #283, support keep_remotely docker_registry_image variable fix: Added support for keep_remotely in docker-build submodule Mar 18, 2022
@antonbabenko
Copy link
Member

Thank you for your contribution! I know that we should have a better process for running pre-commit but we haven't prioritized it yet.

I have updated the version requirement for the docker provider, too.

@antonbabenko antonbabenko merged commit db34260 into terraform-aws-modules:master Mar 18, 2022
antonbabenko pushed a commit that referenced this pull request Mar 18, 2022
@semantic-release-bot
chore(release): version 2.35.1 [skip ci]
1327243 
### [2.35.1](v2.35.0...v2.35.1) (2022-03-18)

### Bug Fixes

* Added support for keep_remotely in docker-build submodule ([#284](#284)) ([db34260](db34260))
@antonbabenko
Copy link
Member

This PR is included in version 2.35.1 🎉

@michaelhelmick michaelhelmick deleted the 283-keep-remotely branch March 18, 2022 13:49
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support keep_remotely variables
2 participants
@michaelhelmick @antonbabenko