Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: overlooked env dumping on DEBUG3 #28

Merged

Conversation

ahlinc
Copy link
Contributor

@ahlinc ahlinc commented Jun 16, 2020

Also removed examples/fixtures/dirtree folder with demo files, there is a script for it.
I'd suggest to make a minor version change for this.

@antonbabenko
Copy link
Member

I know about the script. Here is the explanation why dirtree is there :) There are examples, which always should be possible to execute with the same commands (terraform init, plan, apply) across all terraform-aws-modules repositories. Either change example and remove reference of dirtree there (which is bad, because we want to test with complex dirtree, too), or leave dirtree dirs as is (even if it does not look so nice).

@ahlinc ahlinc force-pushed the fix/dump-env-log-level branch from c395548 to 927e0b6 Compare June 16, 2020 18:57
@antonbabenko antonbabenko changed the title Fix: overlooked env dumping on DEBUG3 fix: overlooked env dumping on DEBUG3 Jun 16, 2020
@antonbabenko antonbabenko merged commit 61f8e87 into terraform-aws-modules:master Jun 16, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants