fix: Fixed event source mapping filter criteria #272
Conversation
sindrig
changed the title
| @@ -262,7 +262,7 @@ resource "aws_lambda_event_source_mapping" "this" { | |||
|
|
|||
| content { | |||
| filter { | |||
| pattern = lookup(filter_criteria, "pattern", null) | |||
| pattern = lookup(each.value["filter_criteria"], "pattern", null) | |||
There was a problem hiding this comment.
I think instead we should change line 261 to
for_each = try(each.value.filter_criteria, [])which should make 265 work as intended without changes (I think, haven't tried myself yet)
There was a problem hiding this comment.
@bryantbiggs This module is still full of lookup() expressions, so using try() is not so critical here.
There was a problem hiding this comment.
I wanted to follow what's done elsewhere in this module. I can change it if you want though.
antonbabenko
changed the title
|
Thanks @sindrig ! |
### [2.34.1](v2.34.0...v2.34.1) (2022-02-23) ### Bug Fixes * Fixed event source mapping filter criteria ([#272](#272)) ([a5c03fe](a5c03fe))
|
This PR is included in version 2.34.1 🎉 |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
This closes #271
Description
See #271
How Has This Been Tested?
examples/*projects