Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add policy_path variable for IAM policies #202

Merged
merged 3 commits into from
Oct 12, 2021
Merged

feat: Add policy_path variable for IAM policies #202

merged 3 commits into from
Oct 12, 2021

Conversation

ekorchison
Copy link
Contributor

@ekorchison ekorchison commented Sep 28, 2021

Description

Add a new variable, policy_path, to pass through as path to any created aws_iam_policy resources.

Motivation and Context

In some cases, the role Terraform assumes is only allowed to manage IAM resources on a specific path. Adding the ability to pass this in means the policies don't have to be managed outside of the module and passed via policies/number_of_policies unnecessarily.

Breaking Changes

None.

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

Added both role_path and policy_path to the complete example, the observed role and policy paths are as expected. As this is a new variable, it should have no impact on the existing code.

@antonbabenko antonbabenko changed the title feat: add policy_path variable feat: Add policy_path variable for IAM policies Oct 12, 2021
@antonbabenko antonbabenko merged commit a13b57c into terraform-aws-modules:master Oct 12, 2021
@antonbabenko
Copy link
Member

Thanks @ekorchison !

v2.22.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants