feat: Added docker pip cache support for macOS #192
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
antonbabenko
changed the title
|
I think you are right, it was an oversight during the release. Merging this one. |
|
v2.13.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allows the docker_pip_cache property to work on macOS.
Motivation and Context
Without this, the docker_pip_cache property is hard-coded to be ignored unless the host platform is Linux.
Breaking Changes
No breaking compatibility.
How Has This Been Tested?
Works great on my Mac, using Docker for Mac, and it's got the M1 chip. I don't see or know why macOS was excluded, unless it was just an oversight in ensuring it didn't happen on Windows.
I could see it not working if the intent was to share a pip cache with the host, but that's not what it's doing. It's just creating a separate directory mapped into the container that gets reused between builds. And that's great! But macOS users would benefit from it, too.