Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Expose ecr tag & scan variables in docker-build module #189

Merged
merged 2 commits into from
Aug 14, 2021

Conversation

codezninja
Copy link
Contributor

@codezninja codezninja commented Aug 13, 2021

Description

Simple PR to expose ECR variables related to image tag mutability & scan on push. Defaults are backward compatible.

Motivation and Context

Give the user the ability to choose lambda image build immutability & vulnerability scanning

Breaking Changes

N/A

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects
cd examples/container-image && \
terraform init && \
terraform apply -target module.docker_image -auto-approve && \
terraform destroy -target module.docker_image -auto-approve

@codezninja codezninja changed the title Expose ecr tag & scan variables in docker-build module feat: Expose ecr tag & scan variables in docker-build module Aug 13, 2021
@antonbabenko antonbabenko merged commit 12d1a65 into terraform-aws-modules:master Aug 14, 2021
@antonbabenko
Copy link
Member

Thanks, @bondezbond !

v2.8.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants