feat: Add recreate_missing_package parameter
#181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pdecat
force-pushed
the
add_recreate_missing_lambda_package_parameter
branch
from
2610afe to
f5487f1
Compare
pdecat
changed the title
recreate_missing_package parameterrecreate_missing_package parameter
pdecat
force-pushed
the
add_recreate_missing_lambda_package_parameter
branch
from
f5487f1 to
47f5030
Compare
pdecat
force-pushed
the
add_recreate_missing_lambda_package_parameter
branch
from
ab703f2 to
3a4ea75
Compare
…TE_MISSING_LAMBDA_PACKAGE environment variable
pdecat
force-pushed
the
add_recreate_missing_lambda_package_parameter
branch
from
204dd33 to
de88158
Compare
|
One more for today. Is it ready for the final review? |
|
Yep, ready for review :) |
|
Thanks a lot for this fix, too! v2.16.0 has been just released. |
This was referenced Sep 8, 2021
1 task
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add
recreate_missing_packageparameter in addition toTF_RECREATE_MISSING_LAMBDA_PACKAGEenvironment variable.Motivation and Context
People can forget defining the
TF_RECREATE_MISSING_LAMBDA_PACKAGEenvironment variable tofalsebefore runningterraform planorterraform apply, leading to undesired diff.Adding this as a parameter, we can make sure it is always defined when desired.
Breaking Changes
N/A
How Has This Been Tested?
examples/*projectsWhen the
TF_RECREATE_MISSING_LAMBDA_PACKAGEenvironment variable is set totrueorfalse, it takes precedence over the newrecreate_missing_packageparameter which defaults totrue.