Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Updated README with S3 bucket id handling #157

Merged
merged 3 commits into from
Jun 7, 2021
Merged

Conversation

zekth
Copy link
Contributor

@zekth zekth commented Jun 7, 2021

Description

Adding precisions regarding the S3 bucket handling.

Motivation and Context

I faced validation issues because i was using the arn instead of the id of the bucket. As i saw similar people having this issue on internet, i thought it would be better to clarify this in the documentation.

Breaking Changes

None

@zekth zekth changed the title doc: S3 id handling docs: S3 id handling Jun 7, 2021
Copy link
Member

@antonbabenko antonbabenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

variables.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title docs: S3 id handling docs: Updated README with S3 bucket id handling Jun 7, 2021
@antonbabenko antonbabenko merged commit d922025 into terraform-aws-modules:master Jun 7, 2021
@antonbabenko
Copy link
Member

Thanks, @zekth !

v2.4.0 has been just released.

@zekth zekth deleted the doc_s3 branch June 7, 2021 14:15
@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants