Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add s3_acl and s3_server_site_encryption variables #120

Merged
merged 4 commits into from
Mar 2, 2021

Conversation

tcharewicz
Copy link
Contributor

@tcharewicz tcharewicz commented Mar 2, 2021

Description

adding variable acl and server_site_encryption for s3_bucket_object resource

Motivation and Context

my bucket where I keep lambda code is encrypted and has different acl

Breaking Changes

nope

How Has This Been Tested?

on internal dev env

variables.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
@antonbabenko antonbabenko changed the title adding variables acl and server_site_encryption to TF module feat: Add s3_acl and s3_server_site_encryption variables Mar 2, 2021
@antonbabenko antonbabenko merged commit a85cfb3 into terraform-aws-modules:master Mar 2, 2021
@antonbabenko
Copy link
Member

Thanks @tcharewicz !

v1.42.0 has been just released.

@github-actions
Copy link

github-actions bot commented Nov 9, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants