fix: Allow customisation of trusted_role_actions in iam-assumable-role module #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
we need to use sts:TagSession in this module to use aws action on github actions https://github.com/aws-actions/configure-aws-credentials/blob/32a3a7cc43e1aec33c8e06ae413371cfdda97ace/README.md
victormesas
changed the title
|
Hi @antonbabenko can you take a look to this PR? Thanks in advice |
antonbabenko
changed the title
|
Thanks @victormesas for this PR and for sharing a link to the repo. v2.10.0 has been just released. |
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add var to action to can fill out in module iam-assumable-role
Motivation and Context
We use github actions and the AWS action to get credentials need the sts:TagSession permission as you can read on:
https://github.com/aws-actions/configure-aws-credentials/
Breaking Changes
Doesn't apply
How Has This Been Tested?
I tested this changes on my AWS account to ensure that works as I spected