-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: modules/iam-user - Output SMTP password generated with SigV4 algorithm #70
feat: modules/iam-user - Output SMTP password generated with SigV4 algorithm #70
Conversation
modules/iam-user/outputs.tf
Outdated
@@ -57,11 +57,11 @@ output "this_iam_access_key_encrypted_secret" { | |||
} | |||
|
|||
output "this_iam_access_key_ses_smtp_password" { | |||
description = "The secret access key converted into an SES SMTP password" | |||
description = "The secret access key converted into an SES SMTP password by applying AWS's Sigv4 conversion algorithm." |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add another output instead of replacing it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Alright, thanks for quick review!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Done. Updated README as well.
Thanks a lot for speedy merge! |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
This PR changes output value of
this_iam_access_key_ses_smtp_password
iniam-user
submodule from deprecated attributeses_smtp_password
to new oneses_smtp_password_v4
, referencing secret access key converted into an SES SMTP password by applying AWS's documented Sigv4 conversion algorithm.Motivation and Context
The SES SMTP interface no longer supports legacy AWS's SigV2 conversion algorithm and only works with Sigv4:
https://docs.aws.amazon.com/ses/latest/DeveloperGuide/smtp-credentials.html
The change was introduced in AWS provider version
2.50
.https://www.terraform.io/docs/providers/aws/r/iam_access_key.html#ses_smtp_password_v4
hashicorp/terraform-provider-aws#11143
hashicorp/terraform-provider-aws#11144
Breaking Changes
Since the old SigV2 signed passwords no longer work for AWS SES SMTP authentication, there is really no breaking changes. The module will output the SMTP password by converting existing secret access key with the new algorithm.
How Has This Been Tested?
This could be tested by applying the following Terraform file and sending email via regional AWS SES SMTP interface with outputted login and password.