Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add necessary permissions to EFS IRSA policy #233

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

SizZiKe
Copy link
Contributor

@SizZiKe SizZiKe commented Apr 19, 2022

Description

Fixes permissions for the AWS EFS CSI Driver IRSA.

Motivation and Context

Necessary permissions for operation are omitted per the reference policy: https://github.com/kubernetes-sigs/aws-efs-csi-driver/blob/master/docs/iam-policy-example.json

Breaking Changes

N/A

How Has This Been Tested?

  • I have updated at least one of the examples/* to demonstrate and validate my change(s)
  • I have tested and validated these changes using one or more of the provided examples/* projects
  • I have executed pre-commit run -a on my pull request

@bryantbiggs
Copy link
Member

thanks for the PR @SizZiKe - can you update your title to fix: Add necessary permissions to EFS IRSA policy please

@SizZiKe SizZiKe changed the title fix(efs): add necessary permissions fix: Add necessary permissions to EFS IRSA policy Apr 19, 2022
@SizZiKe
Copy link
Contributor Author

SizZiKe commented Apr 19, 2022

thanks for the PR @SizZiKe - can you update your title to fix: Add necessary permissions to EFS IRSA policy please

all set @bryantbiggs

Copy link
Member

@bryantbiggs bryantbiggs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SizZiKe ! good to go @antonbabenko 👍🏽

@antonbabenko antonbabenko merged commit 46da6e9 into terraform-aws-modules:master Apr 19, 2022
antonbabenko pushed a commit that referenced this pull request Apr 19, 2022
### [4.20.2](v4.20.1...v4.20.2) (2022-04-19)

### Bug Fixes

* **efs:** add necessary permissions ([#233](#233)) ([46da6e9](46da6e9))
@antonbabenko
Copy link
Member

This PR is included in version 4.20.2 🎉

@SizZiKe SizZiKe deleted the fix/efs-irsa branch April 19, 2022 13:56
@github-actions
Copy link

github-actions bot commented Nov 8, 2022

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants