-
-
Notifications
You must be signed in to change notification settings - Fork 1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Policy generation when ebs_csi_kms_cmk_ids
is set
#203
fix: Policy generation when ebs_csi_kms_cmk_ids
is set
#203
Conversation
ebs_csi_kms_cmk_ids
is setebs_csi_kms_cmk_ids
is set
ebs_csi_kms_cmk_ids
is setebs_csi_kms_cmk_ids
is set
ebs_csi_kms_cmk_ids
is setebs_csi_kms_cmk_ids
is set
thanks for the PR @schantaraud - we should update the example to include |
Tested with my cluster <3 Thanks @schantaraud |
Closes #211 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@antonbabenko good to go - I can catch up the example later for this
This PR is included in version 4.15.0 🎉 |
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
Fixed a typo causing plan/apply to fail when
ebs_csi_kms_cmk_ids
is set in the"terraform-aws-modules/iam/aws//modules/iam-role-for-service-accounts-eks"
module.Motivation and Context
Without this change, setting
ebs_csi_kms_cmk_ids
results in the following error (statement.value
is1
instead of the list of CMK ARNs):Breaking Changes
None
How Has This Been Tested?
examples/*
projectsTested, with and without setting
ebs_csi_kms_cmk_ids
, as well as with 0, 1 and multiple values.