Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Describe key_name is about AWS EC2 key pairs #970

Merged
merged 1 commit into from
Aug 14, 2020

Conversation

giuscri
Copy link
Contributor

@giuscri giuscri commented Aug 7, 2020

PR o'clock

Description

I feel like people ctrl+f for "key pair", "keypair", "ssh", ... when they look for ways to associate a key pair (that's how AWS calls ssh keys) to worker nodes.

I propose to change the documentation string in local.tf to help users.

Checklist

@giuscri giuscri changed the title Update documentation for workers_group_defaults docs: Describe key_name is about AWS EC2 key pairs Aug 7, 2020
Copy link
Contributor

@dpiddockcmp dpiddockcmp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. Thank you for the PR.

@dpiddockcmp dpiddockcmp merged commit 1c81227 into terraform-aws-modules:master Aug 14, 2020
@giuscri giuscri deleted the patch-2 branch August 14, 2020 13:28
barryib pushed a commit to Polyconseil/terraform-aws-eks that referenced this pull request Oct 25, 2020
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 17, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants