fix: Ensure kubeconfig ends with \n #880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
graywolf-at-work
changed the title
graywolf-at-work
changed the title
dpiddockcmp
reviewed
May 15, 2020
|
@graywolf-at-work Thanks for your contribution. Can you please update your branch, so I can merge it ? |
|
I've rebased on current master. |
In order to be a text file according to POSIX, file needs to be composed of text lines. Text line is defined as sequence of characters ending in \n. Sadly, `~}` did strip everything including the \n, so the kubeconfing did not end with a new line. Output empty string at the end to make sure of it.
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to be a text file according to POSIX, file needs to be composed of
text lines. Text line is defined as sequence of characters ending in \n. Sadly,
~}did strip everything including the \n, so the kubeconfing did not endwith a new line. Output empty string at the end to make sure of it.
PR o'clock
Description
Please explain the changes you made here and link to any relevant issues.
Checklist