fix: Create false #789
Merged
fix: Create false #789
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@dpiddockcmp thanks for your PR. Can you please update your branch according to the new contribution guide and resolve conflicts. You don't need to modify changelog anymore. It's autogenerated with git-chglog. |
barryib
suggested changes
Mar 17, 2020
dpiddockcmp
force-pushed
the
create_false
branch
from
0e122bd to
87c82fb
Compare
Otherwise it gets stuck forever waiting for a cluster that isn't there to respond.
dpiddockcmp
force-pushed
the
create_false
branch
from
87c82fb to
40e6745
Compare
barryib
approved these changes
Mar 18, 2020
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR o'clock
Description
Simple example for the module with
create_eks = falseset. Mainly useful for testing changes that add new resources.This also "fixes" the module so that the plan applies cleanly. It was waiting forever for a non-existent cluster to respond.
Checklist