Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pre-commit terraform_tflint doesn't work locally #721

Closed
1 of 4 tasks
max-rocket-internet opened this issue Jan 29, 2020 · 4 comments · Fixed by #724
Closed
1 of 4 tasks

pre-commit terraform_tflint doesn't work locally #721

max-rocket-internet opened this issue Jan 29, 2020 · 4 comments · Fixed by #724
Assignees

Comments

@max-rocket-internet
Copy link
Contributor

max-rocket-internet commented Jan 29, 2020

I have issues

I'm submitting a...

  • bug report
  • feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

Same for @barryib.

Hopefully @antonbabenko know what's up.

On a Mac in bash shell:

$ pre-commit run --all-files terraform_tflint
Terraform validate with tflint...........................................Failed
hookid: terraform_tflint

/Users/max.williams/.cache/pre-commit/repotsUjgI/terraform_tflint.sh: line 42: pushd: modules/node_groups/node_groups.tf examples/basic/main.tf examples/managed_node_groups/variables.tf examples/launch_templates/variables.tf examples/managed_node_groups/outputs.tf local.tf modules/node_groups: No such file or directory
/Users/max.williams/.cache/pre-commit/repotsUjgI/terraform_tflint.sh: line 42: pushd: examples/managed_node_groups/main.tf modules/node_groups/locals.tf cluster.tf irsa.tf examples/launch_templates/outputs.tf examples/basic/variables.tf examples/spot_instances: No such file or directory
/Users/max.williams/.cache/pre-commit/repotsUjgI/terraform_tflint.sh: line 42: pushd: workers_launch_template.tf examples/spot_instances/variables.tf data.tf variables.tf node_groups.tf examples/basic/outputs.tf examples/spot_instances: No such file or directory
/Users/max.williams/.cache/pre-commit/repotsUjgI/terraform_tflint.sh: line 42: pushd: modules/node_groups/variables.tf modules/node_groups/random.tf examples/launch_templates: No such file or directory
@barryib
Copy link
Member

barryib commented Jan 30, 2020

Sorry wrong button. This PR will fix the problem antonbabenko/pre-commit-terraform#77

@antonbabenko
Copy link
Member

Thanks for pointing to the issue and the solution.

I have just released v1.25.0 of pre-commit-terraform. Please update this repo and let me know if there is anything else pending review/merge.

@barryib
Copy link
Member

barryib commented Jan 30, 2020

It works ! The new release solved the problem.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants