Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support EKS Managed Node Groups #599

Closed
3 tasks
wmorgan6796 opened this issue Nov 19, 2019 · 10 comments
Closed
3 tasks

Support EKS Managed Node Groups #599

wmorgan6796 opened this issue Nov 19, 2019 · 10 comments

Comments

@wmorgan6796
Copy link
Contributor

I have issues

I'm submitting a...

  • bug report
  • [X ] feature request
  • support request - read the FAQ first!
  • kudos, thank you, warm fuzzy

What is the current behavior?

Today AWS announced Managed Node Groups for EKS. This module should strive to support that as quickly as possible. The relevant PR has been merged within the latest release of the AWS provider.

If this is a bug, how to reproduce? Please include a code sample if relevant.

What's the expected behavior?

Supporting managed node groups.

Are you able to fix this problem and submit a PR? Link here if you have already.

Unsure if I'll have time this week to do this, but can get to it next week.

Environment details

  • Affected module version:
  • OS:
  • Terraform version:

Any other relevant info

@reegnz
Copy link

reegnz commented Nov 19, 2019

The terraform aws provider supports it: https://github.com/terraform-providers/terraform-provider-aws/releases/tag/v2.38.0
Pretty nice that AWS takes the terraform aws provider seriously and rolls out the feature on the same day the SDK starts supporting it.

@vishnuhd
Copy link

I am sorry to put it harshly, but approximately when can we use the module for Managed Node Groups?
We are in a sort of dilemma to either continue using this awesome module or create our own for our new EKS cluster.

@wmorgan6796
Copy link
Contributor Author

I think the usefulness of the managed node groups is neutered a bit until we can set kubelet flags.

@max-rocket-internet
Copy link
Contributor

I am sorry to put it harshly, but approximately when can we use the module for Managed Node Groups?

When there's a PR merged for that.

@wmorgan6796
Copy link
Contributor Author

I've filed a pull request for the feature here

@max-rocket-internet
Copy link
Contributor

Nice @wmorgan6796! Perhaps @vishnuhd can test this PR?

@wmorgan6796
Copy link
Contributor Author

wmorgan6796 commented Nov 21, 2019

Linking PR to Issue
#602

@eytanhanig
Copy link
Contributor

Given that we already have variables like worker_groups, worker_groups_launch_template, etc, do we want to use something along the lines of node_groups instead of the more complicated worker_group_managed_node_groups?

@wmorgan6796
Copy link
Contributor Author

The PR associated with this issue has been merged and I will be closing it.

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 29, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants