feat: Add support for specifying conrol plane subnets separate from those used by node groups (data plane) #2113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
changed the title
antonbabenko
approved these changes
Jun 18, 2022
| @@ -331,6 +332,7 @@ module "vpc" { | |||
| azs = ["${local.region}a", "${local.region}b", "${local.region}c"] | |||
| private_subnets = ["10.0.1.0/24", "10.0.2.0/24", "10.0.3.0/24"] | |||
| public_subnets = ["10.0.4.0/24", "10.0.5.0/24", "10.0.6.0/24"] | |||
| intra_subnets = ["10.0.7.0/28", "10.0.7.16/28", "10.0.7.32/28"] | |||
There was a problem hiding this comment.
A good use-case for intra_subnets!
| @@ -44,8 +44,14 @@ variable "cluster_additional_security_group_ids" { | |||
| default = [] | |||
| } | |||
|
|
|||
| variable "control_plane_subnet_ids" { | |||
| description = "A list of subnet IDs where the EKS cluster control plane (ENIs) will be provisioned. Used for expanding the pool of subnets used by nodes/node groups without replacing the EKS control plane" | |||
There was a problem hiding this comment.
ENIs = Elastic Network Interfaces, or what?
There was a problem hiding this comment.
Correct - Elastic Network Interfaces
antonbabenko
pushed a commit
that referenced
this pull request
Jun 18, 2022
## [18.24.0](v18.23.0...v18.24.0) (2022-06-18) ### Features * Add support for specifying conrol plane subnets separate from those used by node groups (data plane) ([#2113](#2113)) ([ebc91bc](ebc91bc))
|
This PR is included in version 18.24.0 🎉 |
|
Kudos @bryantbiggs! That is good scalability opportunity. |
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jul 11, 2022
…hose used by node groups (data plane) (terraform-aws-modules#2113)
spr-mweber3
pushed a commit
to spring-media/terraform-aws-eks
that referenced
this pull request
Jul 11, 2022
## [18.24.0](terraform-aws-modules/terraform-aws-eks@v18.23.0...v18.24.0) (2022-06-18) ### Features * Add support for specifying conrol plane subnets separate from those used by node groups (data plane) ([terraform-aws-modules#2113](terraform-aws-modules#2113)) ([ebc91bc](terraform-aws-modules@ebc91bc))
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
## [18.24.0](terraform-aws-modules/terraform-aws-eks@v18.23.0...v18.24.0) (2022-06-18) ### Features * Add support for specifying conrol plane subnets separate from those used by node groups (data plane) ([#2113](terraform-aws-modules/terraform-aws-eks#2113)) ([6847443](terraform-aws-modules/terraform-aws-eks@6847443))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
1.21references to1.22v1alpha1tov1beta1in examplesMotivation and Context
Breaking Changes
How Has This Been Tested?
examples/*to demonstrate and validate my change(s)examples/*projectspre-commit run -aon my pull request