Support for autoscaling_group_tags in self-managed-node-group module

[juniorz]

Is your request related to a problem? Please describe.

cluster-autoscaler auto-discovery setup relies on tags placed in the ASG (see: https://github.com/kubernetes/autoscaler/blob/master/cluster-autoscaler/cloudprovider/aws/README.md#auto-discovery-setup).

The only option at the moment is to use the variable tags, but that would also apply the tags to security_group, iam_role and instance_profile - which have no use for them.

Using the aws_autoscaling_group_tag resource is also not an option because they should not be combined with managing tags via aws_autoscaling_group directly - which is already used in this module.

Describe the solution you'd like.

A autoscaling_group_tags variable, similarly to iam_role_tags, launch_template_tags, and security_group_tags.

[gferon]

@bryantbiggs if you think this is a good idea, I'm up for implementing it.

[bryantbiggs]

@gferon yes, please feel free to open a PR and I can take a look. Thank you!

[migueleliasweb]

Hi, this seems to also be affecting managed node groups as the tags, when updated, are not being propagated to the underlying ASG.

[maxpschonder]

I think in certain cases it can also be useful to add tags for managed node groups. Since the module itself does not create an auto-scaling group, you could certainly use aws_autoscaling_group_tag for this, or what do you think?
I use a managed-node group and would like to set the tag k8s.io/cluster-autoscaler/node-template/autoscaling-options/scaledownunneededtime on the ASG. Currently I am working around it, but would like to integrate it into this module. Does this make sense from your point of view.

[bryantbiggs]

I think in certain cases it can also be useful to add tags for managed node groups. Since the module itself does not create an auto-scaling group, you could certainly use aws_autoscaling_group_tag for this, or what do you think? I use a managed-node group and would like to set the tag k8s.io/cluster-autoscaler/node-template/autoscaling-options/scaledownunneededtime on the ASG. Currently I am working around it, but would like to integrate it into this module. Does this make sense from your point of view.

Unfortunately, this isn't possible because the ASG does not exist at time of cluster creation. I tried to make this work but its not possible currently #1558 (comment) (embedding the ASG tagging for managed node groups within this module that is)

[antonbabenko]

This issue has been resolved in version 18.23.0 🎉

[github-actions]

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.