Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for "preserve" argument for addons #2054

Closed
romich opened this issue May 3, 2022 · 4 comments · Fixed by #2250
Closed

Add support for "preserve" argument for addons #2054

romich opened this issue May 3, 2022 · 4 comments · Fixed by #2250

Comments

@romich
Copy link

romich commented May 3, 2022

Is your request related to a new offering from AWS?

Is this functionality available in the AWS provider for Terraform? See CHANGELOG.md, too.

  • Yes ✅: 4.10.0

Describe the solution you'd like.

Add support for preserve argument in resource "aws_eks_addon", similar to other arguments.

Describe alternatives you've considered.

Managing addons out of the module.

Additional context

I understand that AWS v4 has significant breaking changes and not all people can or want to upgrade (though v4.9.0 has improvements in this regard), so for now just probing whether setting min version of aws provider to 4.10.0 in this module is something that would be considered.

@bryantbiggs
Copy link
Member

marking as duplicate of #1908 - when that is added this functionality will be supported as well

@bryantbiggs
Copy link
Member

actually keeping it open since its not same source 😅

@antonbabenko
Copy link
Member

This issue has been resolved in version 19.0.0 🎉

@github-actions
Copy link

github-actions bot commented Jan 5, 2023

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 5, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants