Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node group get launch_template_name from node_group_defaults #1945

Closed
bjzhang1101 opened this issue Mar 18, 2022 · 3 comments · Fixed by #1946
Closed

Node group get launch_template_name from node_group_defaults #1945

bjzhang1101 opened this issue Mar 18, 2022 · 3 comments · Fixed by #1946

Comments

@bjzhang1101
Copy link

Is your request related to a new offering from AWS?

No

Is your request related to a problem? Please describe.

We found that launch_template_name in node group can not inherit the value from eks_managed_node_group_defaults like other launch_template related fields like create_launch_template or launch_template_version: https://github.com/terraform-aws-modules/terraform-aws-eks/blob/v18.10.2/node_groups.tf#L276. Instead, it uses the key of the node groups map. Is this intentional?

In our cace, we have multiple node groups per cluster using the same template, this means we need to add the same field for each node groups every time.

Describe the solution you'd like.

Make launch_template_name to inherit value from eks_managed_node_group_defaults.

Describe alternatives you've considered.

Define launch_template_name in every node groups.

Additional context

@antonbabenko
Copy link
Member

This issue has been resolved in version 18.11.0 🎉

@bjzhang1101
Copy link
Author

Thanks! @antonbabenko

@github-actions
Copy link

I'm going to lock this issue because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems similar to this, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants