Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Compact result of cluster security group to avoid disruptive updates when no security groups are supplied #1934

Conversation

bryantbiggs
Copy link
Member

@bryantbiggs bryantbiggs commented Mar 10, 2022

Description

  • Compact result of cluster security group to avoid disruptive updates when no security groups are supplied

Motivation and Context

Breaking Changes

  • No

How Has This Been Tested?

  • I have tested and validated these changes using one or more of the provided examples/* projects

@drunkirishcoder
Copy link

waiting on this fix, can this be merged and released soon?

@bryantbiggs
Copy link
Member Author

@antonbabenko if you get a chance - this should be good to go

@antonbabenko antonbabenko merged commit 5935670 into terraform-aws-modules:master Mar 15, 2022
antonbabenko pushed a commit that referenced this pull request Mar 15, 2022
### [18.10.1](v18.10.0...v18.10.1) (2022-03-15)

### Bug Fixes

* Compact result of cluster security group to avoid disruptive updates when no security groups are supplied ([#1934](#1934)) ([5935670](5935670))
@antonbabenko
Copy link
Member

This PR is included in version 18.10.1 🎉

@bryantbiggs bryantbiggs deleted the fix/compact-cluster-security-groups branch March 15, 2022 21:08
@renato0307
Copy link

@bryantbiggs @antonbabenko Thanks for the fix and release!

@drunkirishcoder
Copy link

thank you for the release!

thunderbird86 pushed a commit to thunderbird86/terraform-aws-eks that referenced this pull request Mar 22, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
spr-mweber3 pushed a commit to spring-media/terraform-aws-eks that referenced this pull request Apr 26, 2022
### [18.10.1](terraform-aws-modules/terraform-aws-eks@v18.10.0...v18.10.1) (2022-03-15)

### Bug Fixes

* Compact result of cluster security group to avoid disruptive updates when no security groups are supplied ([terraform-aws-modules#1934](terraform-aws-modules#1934)) ([5935670](terraform-aws-modules@5935670))
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
it-without-politics pushed a commit to it-without-politics/terraform-aws-eks that referenced this pull request May 23, 2022
### [18.10.1](terraform-aws-modules/terraform-aws-eks@v18.10.0...v18.10.1) (2022-03-15)

### Bug Fixes

* Compact result of cluster security group to avoid disruptive updates when no security groups are supplied ([terraform-aws-modules#1934](terraform-aws-modules#1934)) ([5935670](terraform-aws-modules@5935670))
baibailiha added a commit to baibailiha/terraform-aws-eks that referenced this pull request Sep 13, 2022
### [18.10.1](terraform-aws-modules/terraform-aws-eks@v18.10.0...v18.10.1) (2022-03-15)

### Bug Fixes

* Compact result of cluster security group to avoid disruptive updates when no security groups are supplied ([#1934](terraform-aws-modules/terraform-aws-eks#1934)) ([79c0229](terraform-aws-modules/terraform-aws-eks@79c0229))
@github-actions
Copy link

I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

eks module tries to force cluster recreation if no cluster_security_group_id specified
4 participants