fix: Update examples to show integration and usage of new IRSA submodule #1882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bryantbiggs
force-pushed
the
chore/irsa-example-update
branch
from
a595ff0 to
ecbc621
Compare
bryantbiggs
changed the title
bryantbiggs
commented
Feb 16, 2022
| @@ -234,10 +234,6 @@ resource "aws_eks_addon" "this" { | |||
| ] | |||
| } | |||
|
|
|||
| # Note: if an addon needs to be provisioned ahead of a node group users will | |||
There was a problem hiding this comment.
No longer need this note - this will most likely stay as its defined
| vpc_cni_enable_ipv6 = true | ||
|
|
||
| oidc_providers = { | ||
| ex = { |
There was a problem hiding this comment.
ex is what you called main in another module (iam), right? main seems more descriptive to me.
There was a problem hiding this comment.
fixed all references in 94c0309
antonbabenko
pushed a commit
that referenced
this pull request
Feb 16, 2022
### [18.7.2](v18.7.1...v18.7.2) (2022-02-16) ### Bug Fixes * Update examples to show integration and usage of new IRSA submodule ([#1882](#1882)) ([8de02b9](8de02b9))
|
This PR is included in version 18.7.2 🎉 |
baibailiha
added a commit
to baibailiha/terraform-aws-eks
that referenced
this pull request
Sep 13, 2022
### [18.7.2](terraform-aws-modules/terraform-aws-eks@v18.7.1...v18.7.2) (2022-02-16) ### Bug Fixes * Update examples to show integration and usage of new IRSA submodule ([#1882](terraform-aws-modules/terraform-aws-eks#1882)) ([1776faa](terraform-aws-modules/terraform-aws-eks@1776faa))
|
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Motivation and Context
Breaking Changes
How Has This Been Tested?
examples/*projects