-
-
Notifications
You must be signed in to change notification settings - Fork 4.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add launch_template_tags variable for additional launch template tags #1835
feat: Add launch_template_tags variable for additional launch template tags #1835
Conversation
Co-authored-by: Bryant Biggs <[email protected]>
I almost forgot - we'll need to update self-managed node groups module as well, and then propagate those changes up to the root |
@bryantbiggs |
do you have pre-commit installed? in this repo it can take quite some time - you can get around this with (executed from project root):
|
@bryantbiggs |
@bryantbiggs how about now? |
Co-authored-by: Bryant Biggs <[email protected]>
Co-authored-by: Bryant Biggs <[email protected]>
The correction was omitted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for your efforts @kahirokunn 🎉
good to go 👍🏽 @antonbabenko
Thanks for all the advice! |
## [18.3.0](v18.2.7...v18.3.0) (2022-02-03) ### Features * Add launch_template_tags variable for additional launch template tags ([#1835](#1835)) ([9186def](9186def))
This PR is included in version 18.3.0 🎉 |
## [18.3.0](terraform-aws-modules/terraform-aws-eks@v18.2.7...v18.3.0) (2022-02-03) ### Features * Add launch_template_tags variable for additional launch template tags ([#1835](terraform-aws-modules/terraform-aws-eks#1835)) ([170ea31](terraform-aws-modules/terraform-aws-eks@170ea31))
I'm going to lock this pull request because it has been closed for 30 days ⏳. This helps our maintainers find and focus on the active issues. If you have found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Description
add "launch_template_ignore_changes" option
Motivation and Context
If I add a tag to
var.tags
, it will be added to all of them, but there was a situation where I wanted to add an arbitrary tag only to the specifications_tags of launch_template_tag, and I want to make it supported.Breaking Changes
How Has This Been Tested?